This repository has been archived by the owner on Jun 19, 2024. It is now read-only.
Fix #1715: ApplyService#applyProjectRequest should be (truly) idempotent #1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikgb
reviewed
Oct 1, 2019
| @@ -1071,6 +1075,9 @@ public boolean applyProject(Project project) { | |||
| * Returns true if the ProjectRequest is created | |||
| */ | |||
| public boolean applyProjectRequest(ProjectRequest entity) { | |||
| // Check whether project creation attempted before | |||
| if (projectsCreated.contains(getName(entity))) | |||
| return true; | |||
There was a problem hiding this comment.
According to the method signature, I think the return value should be false if projectsCreated contains getName(entity)
There was a problem hiding this comment.
Nice catch! Thanks 👍
rohanKanojia
force-pushed
the
pr/issue1715
branch
from
bdd0b02
to
1d38fe6
Compare
devang-gaur
suggested changes
Oct 3, 2019
| @@ -1071,6 +1075,9 @@ public boolean applyProject(Project project) { | |||
| * Returns true if the ProjectRequest is created | |||
| */ | |||
| public boolean applyProjectRequest(ProjectRequest entity) { | |||
| // Check whether project creation attempted before | |||
| if (projectsCreated.contains(getName(entity))) | |||
There was a problem hiding this comment.
@rohanKanojia curly brackets, please!
rohanKanojia
force-pushed
the
pr/issue1715
branch
from
1d38fe6
to
c861dca
Compare
devang-gaur
approved these changes
Oct 3, 2019
rohanKanojia
added
the
jkube/pending
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this pull request
Nov 7, 2019
rohanKanojia
removed
the
jkube/pending
rohanKanojia
added a commit
to eclipse-jkube/jkube
that referenced
this pull request
Nov 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1715