-
Notifications
You must be signed in to change notification settings - Fork 202
Add Open Liberty Generator #1711
Add Open Liberty Generator #1711
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this PR 👍
Could you please add unit test for OpenLibertyGenerator and a sample project/integration test for this as well? Also, would be super awesome if we can add it to our website documentation (docs/ folder)
|
||
public class OpenLibertyGenerator extends JavaExecGenerator { | ||
|
||
private static final Object LIBERTY_SELF_EXTRACTOR = "wlp.lib.extract.SelfExtractRun"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, indentation slightly off here
@rohanKanojia Sure, I didn't add unit tests initially because I didn't see them for most other generators. I added a couple of simple tests and documentation in the latest commit. I can add a more in depth sample later. |
@brenthdaniel : cool, thanks. Looking forward to getting this merged 😄 |
a82fb64
to
983c0ef
Compare
Codecov Report
@@ Coverage Diff @@
## master #1711 +/- ##
============================================
+ Coverage 33.98% 34.18% +0.19%
- Complexity 1105 1112 +7
============================================
Files 189 190 +1
Lines 10713 10769 +56
Branches 1745 1752 +7
============================================
+ Hits 3641 3681 +40
- Misses 6650 6661 +11
- Partials 422 427 +5 |
@rohanKanojia Hi, is there anything else needed for this PR? |
@brenthdaniel : just a tiny entry to changelog about this new feature 😄 |
+ Add a generator for Open Liberty that extends the java-exec generator. It defaults webPort to the Liberty default port (9080) and adds an environment variable for use by S2I if it detects a Liberty runnable jar. + Add Liberty's default web ports (9080, 9443) to the ExposeEnricher so that routes get generated.
+ Add a generator for Open Liberty that extends the java-exec generator. It defaults webPort to the Liberty default port (9080) and adds an environment variable for use by S2I if it detects a Liberty runnable jar. + Add Liberty's default web ports (9080, 9443) to the ExposeEnricher so that routes get generated.
+ Add a generator for Open Liberty that extends the java-exec generator. It defaults webPort to the Liberty default port (9080) and adds an environment variable for use by S2I if it detects a Liberty runnable jar. + Add Liberty's default web ports (9080, 9443) to the ExposeEnricher so that routes get generated.
+ Add a generator for Open Liberty that extends the java-exec generator. It defaults webPort to the Liberty default port (9080) and adds an environment variable for use by S2I if it detects a Liberty runnable jar. + Add Liberty's default web ports (9080, 9443) to the ExposeEnricher so that routes get generated.
+ Add a generator for Open Liberty that extends the java-exec generator. It defaults webPort to the Liberty default port (9080) and adds an environment variable for use by S2I if it detects a Liberty runnable jar. + Add Liberty's default web ports (9080, 9443) to the ExposeEnricher so that routes get generated.
Two pieces here: