This repository has been archived by the owner on Jun 19, 2024. It is now read-only.
Fixes #1042 Switch to using Deployments rather than DeploymentConfig on OpenShift when not using ImageStreams #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1096 +/- ##
============================================
- Coverage 25.28% 25.27% -0.02%
Complexity 703 703
============================================
Files 176 176
Lines 9368 9374 +6
Branches 1617 1619 +2
============================================
Hits 2369 2369
- Misses 6731 6737 +6
Partials 268 268 |
rohanKanojia
changed the title
rohanKanojia
force-pushed
the
bugfix1042
branch
from
37de7b3 to
d4b8d5c
Compare
hrishin
suggested changes
Nov 27, 2017
There was a problem hiding this comment.
@rohanKanojia Thanks :)
Overall it's looking good, could you accommodate following changes
- update the F8-M-P documentation about this flag change
- update the changelog.md about this feature change
| @@ -174,6 +175,8 @@ | |||
| @Parameter(property = "fabric8.build.strategy") | |||
| private OpenShiftBuildStrategy buildStrategy = OpenShiftBuildStrategy.s2i; | |||
|
|
|||
| @Parameter(property = "fabric8.build.switchToDeployment", defaultValue = "true") | |||
There was a problem hiding this comment.
Would it be better to keep the default preference to false, so it will not impact the existing deployments and users who are using it :)
@jstrachan WDYT?
Switch to using Deployments rather than DeploymentConfig on OpenShift when not using ImageStreams
rohanKanojia
force-pushed
the
bugfix1042
branch
from
d4b8d5c to
810f9c3
Compare
rohanKanojia
force-pushed
the
bugfix1042
branch
from
810f9c3 to
f5206f9
Compare
rohanKanojia
force-pushed
the
bugfix1042
branch
from
f5206f9 to
bcf3df8
Compare
hrishin
approved these changes
Nov 28, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fabric8-maven-plugin should always use DeploymentConfigs if using ImageStreams; but if not we should probably default to Deployments.