Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

Add support for Istio Kubeinject via new enricher #1119

Closed
kameshsampath opened this issue Dec 1, 2017 · 3 comments
Closed

Add support for Istio Kubeinject via new enricher #1119

kameshsampath opened this issue Dec 1, 2017 · 3 comments
Assignees
@hrishin
Labels
cat/feature Feature request status/stale Issue/PR considered to be stale

Comments

@kameshsampath
Copy link
Contributor

Add support for doing Istio Kubeinject for applications that might need Istio support

A part of the enricher has been written https://github.com/kameshsampath/fmp-istio-enricher

Some issues that are related to this are #968 , #969

Description

The fabric8 maven plugin need to add istio sidecars and init containers with needed metadata to the applications that needs to use istio service mesh

Info

  • f-m-p version : 3.5.33 and above
  • Maven version (mvn -v) : 3.5.x
  • Kubernetes / OpenShift setup and version : Kubenretes >= 1.7/ OpenShift >=3.7
  • If it's a feature request, what is your use case : Support for Istio Kube Inject
  • Sample project : https://github.com/kameshsampath/fmp-istio-enricher
@kameshsampath kameshsampath added the cat/feature Feature request label Dec 1, 2017
kameshsampath added a commit to kameshsampath/fabric8-maven-plugin that referenced this issue Dec 1, 2017
@kameshsampath
Implementing fabric8io#1119
592260f 
 - basic working version with sidecars, initcontainers added to app
 - added profile called "servicemesh" which need to be added to fmp config to enable this istio enrichers

WIP:
 - UT cases
 - failing with OpenShift, as Openshift deployment unable to lookup the image ??? related to fabric8io#1042
 - IT cases
kameshsampath added a commit to kameshsampath/fabric8-maven-plugin that referenced this issue Dec 4, 2017
@kameshsampath
Implementing fabric8io#1119
be22621 
 - basic working version with sidecars, initcontainers added to app
 - added profile called "servicemesh" which need to be added to fmp config to enable this istio enrichers

WIP:
 - UT cases
 - failing with OpenShift, as Openshift deployment unable to lookup the image ??? related to fabric8io#1042
 - IT cases
@hrishin hrishin self-assigned this Jan 3, 2018
@hrishin hrishin modified the milestone: Sprint 143 Jan 3, 2018
@hrishin hrishin added Epic A larger user story and removed Epic A larger user story labels Jan 22, 2018
@hrishin
Copy link
Member

hrishin commented Jan 22, 2018

#1164

@hrishin hrishin modified the milestone: Sprint 144 H Jan 22, 2018
@piyush-garg piyush-garg mentioned this issue Feb 27, 2018
Open
30 tasks
@stale
Copy link

stale bot commented Oct 4, 2018

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale Issue/PR considered to be stale label Oct 4, 2018
@rohanKanojia
Copy link
Member

Covered in #1164, so closing

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hrishin hrishin

Labels
cat/feature Feature request status/stale Issue/PR considered to be stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kameshsampath @rohanKanojia @hrishin