issue #1834: Refactor to Replace Guava with JDK Built-In Functionalities #1836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mdxabu <[email protected]>
…java Signed-off-by: mdxabu <[email protected]>
rohanKanojia
force-pushed
the
issue1834
branch
from
8f2b3fc to
2109ac2
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rohanKanojia, This PR refactors several classes by replacing Guava-specific collections and utilities with their corresponding Java Standard Library counterparts #1834. The following changes have been made:
AbstractDockerMojo.java:ImmutableListwithListand usedArrayListto build the list andCollections.unmodifiableListfor immutability.ContainerNamingUtil.java:ImmutableSetwithHashSetand switched toCollections.unmodifiableSetfor immutability.CredentialHelperClient.java:JoinerwithString.join()andLists.newLinkedList()withnew LinkedList<>().ImageNameFormatter.java:Strings.isNullOrEmpty()withString.isNullOrEmpty().JibServiceUtil.java:Please review and merge when ready. Feel free to let me know if you have any questions or concerns.