Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker build cache friendly example updated #1828

Merged
merged 2 commits into from
Oct 12, 2024
Merged

Docker build cache friendly example updated #1828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59de505
Compatibility of build-cache sample with recent versions of Docker En…
mabrarov Oct 3, 2024
ee9dc73
Upgrade of Maven Assembly Plugin in build-cache sample till the lates…
mabrarov Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 26 additions & 14 deletions samples/build-cache/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,24 +30,36 @@ When building the project multiple times, note that subsequent builds log "Using
```
$ mvn clean package
...
[INFO] DOCKER> Step 1 : FROM gcr.io/distroless/java-debian10
[INFO] DOCKER> ---> f6a5dc137f9b
[INFO] DOCKER> Step 2 : USER nonroot
[INFO] DOCKER> Step 1/10 : FROM gcr.io/distroless/java-debian10
[INFO] DOCKER>
[INFO] DOCKER> ---> 444adf12984c
[INFO] DOCKER> Step 2/10 : USER nonroot
[INFO] DOCKER>
[INFO] DOCKER> ---> Using cache
[INFO] DOCKER> ---> 26d64b9907e3
[INFO] DOCKER> Step 3 : ENTRYPOINT
[INFO] DOCKER> ---> 043b487914d1
[INFO] DOCKER> Step 3/10 : WORKDIR "/app"
[INFO] DOCKER>
[INFO] DOCKER> ---> Using cache
[INFO] DOCKER> ---> 6eb12980cd38
[INFO] DOCKER> Step 4 : WORKDIR "/app"
[INFO] DOCKER> ---> 08ef41fef30f
[INFO] DOCKER> Step 4/10 : CMD ["tini", "-e", "130", "-e", "143", "--", "java", "org.springframework.boot.loader.JarLauncher"]
[INFO] DOCKER>
[INFO] DOCKER> ---> Using cache
[INFO] DOCKER> ---> d6a408147d7c
[INFO] DOCKER> Step 5 : CMD tini -e 130 -e 143 -- java org.springframework.boot.loader.JarLauncher
[INFO] DOCKER> ---> 2ac94352abe0
[INFO] DOCKER> Step 5/10 : ADD ["dependencies.tar", "/"]
[INFO] DOCKER>
[INFO] DOCKER> ---> Using cache
[INFO] DOCKER> ---> 461505b7ade9
[INFO] DOCKER> Step 6 : ADD dependencies.tar /
[INFO] DOCKER> ---> aafdf67c0508
[INFO] DOCKER> Step 6/10 : ADD ["spring-boot-loader.tar", "/"]
[INFO] DOCKER>
[INFO] DOCKER> ---> Using cache
[INFO] DOCKER> ---> df87a8d003f3
[INFO] DOCKER> Step 7 : ADD spring-boot-loader.tar /
[INFO] DOCKER> ---> f593e7c3c58d
[INFO] DOCKER> Step 7/10 : ADD ["snapshot-dependencies.tar", "/"]
[INFO] DOCKER>
[INFO] DOCKER> ---> Using cache
[INFO] DOCKER> ---> 2de1bf3ac9ad
[INFO] DOCKER> ---> ef1f89b783b5
[INFO] DOCKER> Step 8/10 : ADD ["application.tar", "/"]
[INFO] DOCKER>
[INFO] DOCKER> ---> Using cache
[INFO] DOCKER> ---> 055ba36bb45f
...
```
2 changes: 1 addition & 1 deletion samples/build-cache/app/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

<properties>
<!-- Avoid docker build cache invalidation due to new commits -->
<project.build.outputTimestamp>1970-01-01T00:00:00Z</project.build.outputTimestamp>
<project.build.outputTimestamp>2000-01-01T00:00:00Z</project.build.outputTimestamp>
</properties>

<dependencies>
Expand Down
2 changes: 1 addition & 1 deletion samples/build-cache/image/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

<image>fabric8/dmp-sample-build-cache-app:${project.version}</image>
<!-- Avoid docker build cache invalidation due to new commits -->
<project.build.outputTimestamp>1970-01-01T00:00:00Z</project.build.outputTimestamp>
<project.build.outputTimestamp>2000-01-01T00:00:00Z</project.build.outputTimestamp>
<tini.sha512>8053cc21a3a9bdd6042a495349d1856ae8d3b3e7664c9654198de0087af031f5d41139ec85a2f5d7d2febd22ec3f280767ff23b9d5f63d490584e2b7ad3c218c</tini.sha512>

<tini.version>0.19.0</tini.version>
Expand Down
10 changes: 5 additions & 5 deletions samples/build-cache/image/src/main/docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,6 @@ FROM gcr.io/distroless/java-debian10
# Just for security
USER nonroot

# Entry point of the base image executes java which we don't need because we use tini in the image command.
# tini (https://github.com/krallin/tini) is used to enforce zero exit code when Java application is stopped
# using SIGINT or SIGTERM.
ENTRYPOINT []

# /app directory contains all items of the wanted Java class path.
WORKDIR "/app"

Expand All @@ -32,6 +27,11 @@ ADD ["snapshot-dependencies.tar", "/"]
# ... application code
ADD ["application.tar", "/"]

# Entry point of the base image executes java which we don't need because we use tini in the image command.
# tini (https://github.com/krallin/tini) is used to enforce zero exit code when Java application is stopped
# using SIGINT or SIGTERM.
ENTRYPOINT []

# Put version into the last layer because LABEL directive produces more lightweight layer than ADD.
LABEL name="@{image}" \
version="@{project.version}"
2 changes: 1 addition & 1 deletion samples/build-cache/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
<git-commit-id-plugin.version>4.0.3</git-commit-id-plugin.version>

<git.commit.dateFormat>yyyy-MM-dd'T'HH:mm:ssXXX</git.commit.dateFormat>
<maven-assembly-plugin.version>3.3.0</maven-assembly-plugin.version>
<maven-assembly-plugin.version>3.5.0</maven-assembly-plugin.version>
<maven-jar-plugin.version>3.2.0</maven-jar-plugin.version>
<maven.compiler.source>1.8</maven.compiler.source>
<maven.compiler.target>1.8</maven.compiler.target>
Expand Down
Loading