Fix logic bug to remove dangling images

[romank8k]

Hi @rohanKanojia,
As a follow up to #1513, I've been testing a private build of the changes on our CI machines, and discovered a logic bug.
The condition to remove the image only if there are no other associated tags/repos should be reversed.

Additionally I'm looking to address one other scenario of dangling images.
That happens when pushing tags.
For example, the following code could result in a dangling image that will never be cleaned up, so I'm thinking of extending the logic to clean it up here as well.

        if (alreadyHasImage) {
            log.warn("Target image '%s' already exists. Tagging of '%s' will replace existing image",
                targetImage, fullName);
        }

[codecov]

Codecov Report

Merging #1522 (4bb9a78) into master (1a8a9ad) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1522      +/-   ##
============================================
+ Coverage     61.93%   62.01%   +0.07%     
- Complexity     2186     2189       +3     
============================================
  Files           167      167              
  Lines          9645     9645              
  Branches       1455     1455              
============================================
+ Hits           5974     5981       +7     
+ Misses         3145     3139       -6     
+ Partials        526      525       -1     

Impacted Files	Coverage Δ
.../io/fabric8/maven/docker/service/BuildService.java	57.08% <100.00%> (+2.68%)	⬆️

[rohanKanojia]

hmm makes sense. Could you please add a test for this too?

[romank8k]

hi @rohanKanojia, sure I'll work on adding some test cases too.

[rohanKanojia]

@rkhmelichek : I plan to cut 0.39.0 probably today or tomorrow. Do you think we should include this PR in that?

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

[romank8k]

@rohanKanojia, yes thanks for merging!
I will open a new pull request for handling dangling images as a result of pushing tags (and work on tests too).