Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add startPeriod to healthCheck #1022

Merged
merged 1 commit into from
May 15, 2018
Merged

Add startPeriod to healthCheck #1022

merged 1 commit into from
May 15, 2018

Conversation

ollie1
Copy link
Contributor

@ollie1 ollie1 commented May 15, 2018

Addresses issue #961. A startPeriod may now be specified in the health
check in the POM. This works in the same way as adding a start-period
option to a Dockerfile.

Addresses issue #961.  A startPeriod may now be specified in the health
check in the POM.  This works in the same way as adding a start-period
option to a Dockerfile.

Signed-off-by: Oliver Lambert <[email protected]>
@codecov
Copy link

codecov bot commented May 15, 2018

Codecov Report

Merging #1022 into master will increase coverage by 0.03%.
The diff coverage is 87.5%.

@@             Coverage Diff              @@
##             master    #1022      +/-   ##
============================================
+ Coverage     51.75%   51.78%   +0.03%     
- Complexity     1367     1369       +2     
============================================
  Files           147      147              
  Lines          7472     7479       +7     
  Branches       1134     1135       +1     
============================================
+ Hits           3867     3873       +6     
- Misses         3240     3241       +1     
  Partials        365      365
Impacted Files Coverage Δ Complexity Δ
...config/handler/property/PropertyConfigHandler.java 71.9% <0%> (-0.35%) 109 <0> (ø)
.../maven/docker/config/HealthCheckConfiguration.java 78.94% <100%> (+1.8%) 16 <1> (+2) ⬆️
...abric8/maven/docker/assembly/DockerFileOption.java 100% <100%> (ø) 4 <0> (ø) ⬇️
...aven/docker/config/handler/property/ConfigKey.java 100% <100%> (ø) 10 <0> (ø) ⬇️
...bric8/maven/docker/assembly/DockerFileBuilder.java 90.33% <100%> (+0.04%) 77 <0> (ø) ⬇️

Copy link
Collaborator

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks ! lgtm

@rhuss rhuss merged commit 9c92872 into fabric8io:master May 15, 2018
@ollie1 ollie1 deleted the issue961 branch May 17, 2018 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants