We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I have a port mapping config like the following:
<run> <ports> <port>+docker.ondemand.postgres.host:docker.ondemand.postgres.port:5432</port> </ports> </run>
Ordinarily, I can access ${docker.ondemand.postgres.host} & ${docker.ondemand.postgres.port} after the docker container has started.
${docker.ondemand.postgres.host}
${docker.ondemand.postgres.port}
But if I specify -Ddocker.ondemand.postgres.port=5432 then docker.ondemand.postgres.host is not dynamically set.
-Ddocker.ondemand.postgres.port=5432
docker.ondemand.postgres.host
This appears to be because of the following snippet in org.jolokia.docker.maven.service.RunService#createAndStartContainer
org.jolokia.docker.maven.service.RunService#createAndStartContainer
if (mappedPorts.containsDynamicPorts()) { updateMappedPorts(id, mappedPorts); }
Changing it to
if (mappedPorts.containsDynamicPorts() || mappedPorts.containsDynamicHostIps()) { updateMappedPorts(id, mappedPorts); }
seems to fix this bug, so I'll raise a PR for this.
The text was updated successfully, but these errors were encountered:
Update dynamic host prop even without dynamic port prop
cd994e7
Fixes fabric8io#323
+1, I also ran into this issue lately.
Sorry, something went wrong.
Thanks, PR applied for 0.13.7
a1c4a6c
Merge pull request fabric8io#323 from egelev/add-image-save-conf
6bf58c5
Add option to the build mojo which allows 'docker save' on image
rhuss
No branches or pull requests
I have a port mapping config like the following:
Ordinarily, I can access
${docker.ondemand.postgres.host}
&${docker.ondemand.postgres.port}
after the docker container has started.But if I specify
-Ddocker.ondemand.postgres.port=5432
thendocker.ondemand.postgres.host
is not dynamically set.This appears to be because of the following snippet in
org.jolokia.docker.maven.service.RunService#createAndStartContainer
Changing it to
seems to fix this bug, so I'll raise a PR for this.
The text was updated successfully, but these errors were encountered: