Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait timeout reports 0ms when timeout with default maxwait #274

Closed
mgurov opened this issue Aug 29, 2015 · 3 comments
Closed

Wait timeout reports 0ms when timeout with default maxwait #274

mgurov opened this issue Aug 29, 2015 · 3 comments

Comments

@mgurov
Copy link
Contributor

mgurov commented Aug 29, 2015

Given wait configuration:

                <wait>
                  <log>never to be seen</log>
                </wait>

the output of the docker:run after 10 seconds is:

[ERROR] DOCKER> [local/bes] : Timeout after 0 ms while waiting on log out 'never to be seen'

Expected the actual time waited or maxwait expected to be reported.
mgurov added a commit to mgurov/docker-maven-plugin that referenced this issue Aug 29, 2015
@mgurov
fabric8io#274 - report actual time waited when default maxwait for a…
a824a6a 
…sked for
@mgurov mgurov mentioned this issue Aug 29, 2015
Closed
@rhuss
Copy link
Collaborator

rhuss commented Aug 30, 2015

Thanks for the report. Indeed if the default timeout occurs it should be reported. 'will apply the PR ASAP. In the meantime, could you please sign-off you commit as described here

Thanks !

mgurov added a commit to mgurov/docker-maven-plugin that referenced this issue Aug 30, 2015
@mgurov
fabric8io#274 - report actual time waited when default maxwait for a…
d258879 
…sked for

Signed-off-by: Mykola Gurov <[email protected]>
@mgurov
Copy link
Contributor Author

mgurov commented Aug 30, 2015

Signed off. I did have a feeling that I missed something.

rhuss pushed a commit that referenced this issue Aug 30, 2015
@mgurov @rhuss
#274 - report actual time waited when default maxwait for asked for
3874b79 
Signed-off-by: Mykola Gurov <[email protected]>
@rhuss
Copy link
Collaborator

rhuss commented Aug 30, 2015

Applied PR to branch integration. Available in 0.13.4.

Thanks !

@rhuss rhuss closed this as completed Aug 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rhuss @mgurov