Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow killing and removing all spawned containers #1182

Closed
ivanfryda opened this issue Mar 27, 2019 · 5 comments · Fixed by #1298
Closed

Allow killing and removing all spawned containers #1182

ivanfryda opened this issue Mar 27, 2019 · 5 comments · Fixed by #1298
Assignees

Comments

@ivanfryda
Copy link

We use the maven plugin for integration testing. The stopping of every container in a sequential order takes some time. As it is used just for testing, it would be better if the plugin could offer a mechanism to execute docker kill on every container, which should be almost immediate.

@rhuss
Copy link
Collaborator

rhuss commented Apr 6, 2019

Not sure if I understand you correctly when you say 'kill on every' container, and why this is faster than proper docker:stop.

@danielwegener
Copy link
Contributor

danielwegener commented Nov 8, 2019

I think he means that a regular docker stop would wait for the process to terminate correctly while a hard docker rm -f would terminate the process with a sigkill which is faster for some heavy application servers.

@rhuss
Copy link
Collaborator

rhuss commented Nov 21, 2019

I see and think it might be a valid use case for testing. I'm positive for adding a stopMode to RunImageConfiguration with e.g. possible values graceful and kill and implementing the proper semantics.

However, I can't do the coding but would happy to support a submitted PR (if you have some patience, as I'm really low on time which I can spend on d-m-p)

@rohanKanojia
Copy link
Member

@rhuss : Shall I look into this?

@rohanKanojia rohanKanojia self-assigned this Nov 21, 2019
@rhuss
Copy link
Collaborator

rhuss commented Nov 21, 2019

@rohanKanojia would be awesome. You are the best ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants