Adding support for Secrets #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcnuance
changed the title
|
I know historically cmc is missing tests; so, wondering how can we ensure code quality for such big changes without any tests? secondly if we add "secrets update" to same controller then we should rename it to something different |
|
It's a good idea to add some automated tests. I only tested manually but perhaps we could create a helm chart and do helm test. We could test happy path for each element and may be some raise conditions. |
|
If tests don't exist for the whole project, I don't see the point why a PR should be blocked for missing tests. |
joekohlsdorf
reviewed
Apr 3, 2018
| @@ -2,4 +2,5 @@ FROM scratch | |||
|
|
|||
| ENTRYPOINT ["/configmapcontroller"] | |||
|
|
|||
| COPY bin/kubectl /kubectl | |||
There was a problem hiding this comment.
Can you explain why it is necessary to ship the binary? Is using kubectl the only way to do this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Informer that listens/watches changes in secrets and triggers rolling updates in DaemonSets, Statefulsets and Deployments.