This repository has been archived by the owner on Mar 11, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 86
Actions Board View Rule #2249
Open
michaelkleinhenz
wants to merge
45
commits into
fabric8-services:master
Choose a base branch
from
michaelkleinhenz:actions_staterule
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Actions Board View Rule #2249
Changes from 36 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
353edeb
feat(actions): Actions system infra.
michaelkleinhenz 6ea5c68
fix(tests): Fixed the tests.
michaelkleinhenz be9dae7
fix(doc): Fixed documentation.
michaelkleinhenz 529be05
Merge remote-tracking branch 'upstream/master' into actions_infra
michaelkleinhenz 008f7ff
Merge branch 'master' into actions_infra
michaelkleinhenz 72ad9ce
Merge branch 'master' into actions_infra
michaelkleinhenz ab89650
fix(doc): Added doc.
michaelkleinhenz b7fa5c0
fix(code): Moved Change.
michaelkleinhenz 5589d68
fix(code): Refactoring Change.Set.
michaelkleinhenz f625367
fix(formatting): Format fixed.
michaelkleinhenz 00305cf
fix(staterule): Added state rule.
michaelkleinhenz 88fdfe9
fix(actions): Enabled state rule.
michaelkleinhenz a60efd3
Merge remote-tracking branch 'upstream/master' into actions_staterule
michaelkleinhenz 532ca2f
Fixed formatting.
michaelkleinhenz fa75f51
Fix documentation.
michaelkleinhenz 13d3f53
Merge branch 'master' into actions_staterule
michaelkleinhenz 9aab756
Fixed WIT.
michaelkleinhenz 94ca51e
Fixed golden files.
michaelkleinhenz 0edeacc
Merge remote-tracking branch 'upstream/master' into actions_staterule
michaelkleinhenz e832f8b
Fixed PR comments.
michaelkleinhenz 13640c8
Merge branch 'master' into actions_staterule
michaelkleinhenz 1ce8bd8
Merge remote-tracking branch 'upstream/master' into actions_staterule
michaelkleinhenz 5b4d19c
Fixed group loading.
michaelkleinhenz 4764322
Used id.Slice.
michaelkleinhenz feecf1c
Fixed error reporting.
michaelkleinhenz 4b6acc6
Added test for contains. Fixes memory leak.
michaelkleinhenz 35e6034
Added test for removeElement.
michaelkleinhenz d867145
Added removeElement() test.
michaelkleinhenz dab1b62
Merge remote-tracking branch 'upstream/master' into actions_staterule
michaelkleinhenz f758549
Fixed slice creation.
michaelkleinhenz 649ef2a
Removed debug code.
michaelkleinhenz 58f5187
Fixed equals.
michaelkleinhenz 973fe2d
Fixed isDirty structural inconsistency in onStateChange().
michaelkleinhenz 69d1af4
Fixed err check.
michaelkleinhenz 9a8d624
Fixed leftover bug.
michaelkleinhenz 5001aa2
Changed return type on fuseChanges.
michaelkleinhenz 7dafce4
Fixed tests, removed action instances.
michaelkleinhenz 595316f
Merge branch 'master' into actions_staterule
michaelkleinhenz 6f4d7fb
Fixed empty return bug.
3cb93a2
Removed redundant code.
f83ff16
Updated OnChange() signature to not work with cbr.
9f4de7d
Removed pointer args.
5ff5380
Merge remote-tracking branch 'upstream/master' into actions_staterule
michaelkleinhenz 89c8cb4
Fixed some minor issues.
michaelkleinhenz e71b346
Merge remote-tracking branch 'upstream/master' into actions_staterule
kwk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,7 @@ Package actions system is a key component for process automation in WIT. It prov | |
way of executing user-configurable, dynamic process steps depending on user | ||
settings, schema settings and events in the WIT. | ||
|
||
The idea here is to provide a simple, yet powerful "signal-slot" system that | ||
The idea here is to provide a simple, yet powerful "publish-subscribe" system that | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You have almost the same comment without relating to a package or something in There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @michaelkleinhenz great. But please try to use one commit per comment so it is easy to follow as a reviewer. |
||
can connect any "event" in the system to any "action" with a clear decoupling of | ||
events and actions with the goal of making the associations later dynamic and | ||
configurable by the user ("user connects this event to this action"). Think | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please line comments. Then it is easier to follow what is affected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok.