Skip to content
This repository has been archived by the owner on May 6, 2021. It is now read-only.

Use golang from epel repo #28

Merged
merged 6 commits into from
Jan 9, 2019
Merged

Use golang from epel repo #28

merged 6 commits into from
Jan 9, 2019

Conversation

jarifibrahim
Copy link
Member

@jarifibrahim jarifibrahim commented Dec 10, 2018

See openshiftio/openshift.io#4618

With this PR, we will install golang from the website but we also support installing golang from epel (stable) repo.

@sbose78
Copy link
Member

sbose78 commented Dec 10, 2018

@jarifibrahim jarifibrahim changed the title Use golang from epel Use golang from website Dec 10, 2018
@corinnekrych
Copy link
Contributor

Atm we can not build using golang v1.11 because of goa v1.3 (we need 1.4 see goadesign/goa#1548)
so +1 for proving a way of still installing manually a different version of golang than the one provided by epel-release

@alexeykazakov
Copy link

@corinnekrych you can use goa 1.3 with go 1.11. You just have to use go test -vet off when running tests.

@sbose78
Copy link
Member

sbose78 commented Dec 10, 2018

@jarifibrahim
You would need to use something like this to run the tests

go test -vet off  $(go list ./... | grep -v 'vendor\|app$\|tool\/build-tool-detector-cli\|design\|client\|test')

instead of ginkgo -r ( not sure how to set option for vet )

@corinnekrych to move to goa 1.4.0, client libraries like auth-client would also need to move to 1.4.0

@sbose78 sbose78 changed the title Use golang from website Use golang from epel repo Dec 12, 2018
@corinnekrych corinnekrych merged commit b106da1 into fabric8-services:master Jan 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants