fixes concurrent build issue #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrishin
force-pushed
the
iss#2729-throttle
branch
from
766007f to
c63fe3e
Compare
hrishin
force-pushed
the
iss#2729-throttle
branch
from
9be69cd to
d5ac507
Compare
hrishin
force-pushed
the
iss#2729-throttle
branch
from
d5ac507 to
f910664
Compare
hrishin
force-pushed
the
iss#2729-throttle
branch
from
f910664 to
8adc666
Compare
hrishin
force-pushed
the
iss#2729-throttle
branch
from
f9dbd6f to
1099959
Compare
|
|
||
| @Test | ||
| public void should_add_blocking_properties_from_config_file() throws IOException { | ||
| FreeStyleProject job1 = jenkins.createFreeStyleProject("testJob"); |
There was a problem hiding this comment.
maybe I will call testJob instead of job1
| if(job.getProperty(BuildBlockerProperty.class) == null) { | ||
| try { | ||
| BuildBlockerProperty buildBlockerProperty = BuildBlockerProperty.getDefaultProperties(); | ||
| LOG.log(Level.INFO, "Adding blocking properties "+buildBlockerProperty+" to job "+ job.getName()); |
There was a problem hiding this comment.
Stupid thing, can you add white space between + of string concatenation? Just that is the de-facto format way :)
| job.removeProperty(BuildBlockerProperty.class); | ||
| job.addProperty(property); | ||
| } catch (IOException e) { | ||
|
|
There was a problem hiding this comment.
should we add a log message or something? Just to be sure that we do not loose any important information.
lordofthejars
approved these changes
Jun 5, 2018
hrishin
force-pushed
the
iss#2729-throttle
branch
from
dcff920 to
7d3d109
Compare
- changed the plugin code to manage build throttling configuration from 'Manage Jenkins Configuration' (central) pane - added the job listener to add throttling behavior for new workflow jobs - added unit tests to check build blocking properties - updated README about plugin configuration for fabric8 jenkins deployment - fixed review comments
hrishin
force-pushed
the
iss#2729-throttle
branch
from
7d3d109 to
a8ae9b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes openshiftio/openshift.io#2729