Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CLI Logging and Error Handling #76

Merged
merged 29 commits into from
Oct 7, 2021

Conversation

AkshayBhansali18
Copy link
Contributor

@AkshayBhansali18 AkshayBhansali18 commented Oct 5, 2021

Fix CLI Logging and Error Handling:

  1. Disable dispalying usage when an error is not due user input
  2. Display Appropriate Error message if invalid path to manifest is provided.
  3. Deal with case when server returns an invalid response
  4. Fix typo in Readme

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2021

Codecov Report

Merging #76 (d76888b) into main (da87dbd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #76   +/-   ##
=======================================
  Coverage   35.51%   35.51%           
=======================================
  Files          24       24           
  Lines         870      870           
=======================================
  Hits          309      309           
  Misses        530      530           
  Partials       31       31           
Impacted Files Coverage Δ
cmd/analyse.go 9.80% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da87dbd...d76888b. Read the comment docs.

@jparsai
Copy link

jparsai commented Oct 5, 2021

I think it is better that @sawood14012 and @rafiu007 review it as they know Go better than me. Add proper description so reviewers would know for what purpose PR has been raised and why these changes are been done.

@jparsai
Copy link

jparsai commented Oct 7, 2021

@AkshayBhansali18 you need to rebase and squash commits.

@jparsai
Copy link

jparsai commented Oct 7, 2021

@AkshayBhansali18 first try this on a copy of AkshayBhansali18:cli-logging branch to avoid any issues in this PR.

@AkshayBhansali18 AkshayBhansali18 changed the base branch from main to sawood14012-patch-1 October 7, 2021 11:39
@AkshayBhansali18 AkshayBhansali18 changed the base branch from sawood14012-patch-1 to main October 7, 2021 11:39
Copy link
Member

@sawood14012 sawood14012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants