Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require file arguments to use -- in CLI invocations #389

Merged
merged 2 commits into from
Dec 18, 2022

Conversation

reese
Copy link
Collaborator

@reese reese commented Dec 16, 2022

For whatever reason, when we rewrote the CLI in clap, the last argument was added to the argument for input files. There's not really a good reason for this -- every other flag is just a bool, so there's no other list args -- and we can still support it without requiring it, which is what this PR does. This also lets users do totally reasonable things like run rubyfmt file.rb and then remember to add a -i, so they can just tack it on the end instead of having to put it back at the beginning.

I've opted to leave the -- in the README examples, since the current version in brew doesn't support not using them, but both with and without -- will now work.

@reese reese merged commit f450950 into trunk Dec 18, 2022
@reese reese deleted the reese-double-dash-args branch December 18, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants