Delete version update check #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reese
commented
Dec 15, 2022
| @@ -3,6 +3,7 @@ fn main() { | |||
| #[cfg(target_os = "macos")] | |||
| { | |||
| println!("cargo:rustc-link-lib=framework=foundation"); | |||
| println!("cargo:rustc-link-lib=framework=security"); | |||
There was a problem hiding this comment.
Had to add this to get this working on my M1 -- not sure why it seemed to work for others, although I don't know if most folks use the Makefile (which has this here).
fables-tales
approved these changes
Dec 18, 2022
reese
added a commit
that referenced
this pull request
Sep 12, 2023
* Fix build flag * Delete update functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #386
This version check is neat but ultimately pretty error-prone (and I imagine most users tune it out, given that it's broken on the most recent release and nobody's said anything about it 🤷 ). The version in the
Cargo.tomland on GitHub are not strictly equivalent, so that makes the value of this check far more prone to mistakes and might be annoying/confusing when we mess it up.