Properly multiline user-multilined call chains #382
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #359
In general,
rubyfmt
respects (within limits) user choices about multilining expressions, but we don't currently do this for multiline expressions. This has a few poor side effects: (1) users often want to multiline to make e.g. adding comments for specific sections of a call chain easier, and (2) there end up being some (IMO) awkward formatting of chains like the following:which is inconsistent with
rubyfmt
's normal call chain styling.This PR implements multilining for user-multilined expressions. It does this by checking the line location of the
DotTypeOrOp
items in the call chain and multilining if they're on multiple lines. This might be a slightly imperfect if the user writes something like thisbut IMO this is a reasonable implementation tradeoff. We could alternatively check every expression's start/end, but this ends up requiring a lot more trickery and is more prone to inconsistency.