Handle arbitrary expression types in aref_field nodes
#381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reese
commented
Dec 3, 2022
Comment on lines
+8
to
+21
| a[ | ||
| class A | ||
| def foo | ||
| puts(a) | ||
| end | ||
| end | ||
| ] = "" | ||
| a[ | ||
| begin | ||
| "" | ||
| rescue StandardException | ||
| "" | ||
| end | ||
| ] = "" |
There was a problem hiding this comment.
I'm gonna call this a "reasonable" rendering? I mean, users writing this is already pretty surprising, so I think this is the most consistent way to handle it rather than special-casing aref fields to inline these or something like that 🤷♂️
reese
commented
Dec 3, 2022
| self.line_numbers.len() > 1 || self.any_collapsing_newline_has_heredoc_content() | ||
| self.line_numbers.len() > 1 | ||
| || self.any_collapsing_newline_has_heredoc_content() | ||
| || self.contains_hard_newline() |
There was a problem hiding this comment.
I also think this was a latent bug we've had around forever -- some expressions are essentially always multiline (e.g. classes), so breakables that have these in them should always render multiline.
fables-tales
approved these changes
Dec 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #380
aref_fieldnodes (e.g.foo[:bar] = :baz) can really handle any expression in the index position, and in reality they can handle any number of items for users overriding#[]=, so we should handle an arbitrary expression list here.