Generically handle all method visibility modifiers #369
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #363
Previously we explicitly listed out all "visibility modifiers" like
private
,private_class_method
, etc. to avoid adding extra newlines to them when rendering "method modifiers" likesig
s. However, there will probably always be some we could be missing this way (right now, this includes things likemodule_function
andruby2_keywords
), so this PR changes it such that we generically this for anything of the shapewhich seems more reasonable, especially if a user defined their own special method (like Sorbet's custom
package_private
).