Correctly handle empty Paren
nodes as args
#368
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #367
Method calls like
foo (arg)
are represented withparen
nodes by Ripper, and our deserialization previously assumed that these always had anExpression
in the parens. However, you can still do things likefoo ()
, which Ripper represents as[:paren, false]
instead of something like[:paren,[:void]]
or whatever.Note: it's worth calling out that
foo ()
andfoo
are not technically the same, and that if we're being pedantic the actual output should befoo(())
. Take as example the following:However, simply removing empty parens is the way we currently handle all equivalent cases currently, so that's the method I'm going with for this PR. I also think it's pretty fair to assume that most users would be somewhat surprised by the
foo(())
transformation, and that if that's what you really mean, we can just tell users to usefoo(nil)
instead.