Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support unparenthesized Gemfile methods #358

Merged
merged 2 commits into from
Nov 20, 2022
Merged

Support unparenthesized Gemfile methods #358

merged 2 commits into from
Nov 20, 2022

Conversation

reese
Copy link
Collaborator

@reese reese commented Nov 14, 2022

Resolves #330

This adds support for gem, source, ruby, and group as special unparenthesized methods. This logic is a little duplicated since we separately handle methods with and without blocks (and some of these methods handle both), so I pulled other similar method names out as constants.

@matthewford
Copy link

matthewford commented Nov 19, 2022

it would be good to also add rake tasks, and rails routes

@reese
Copy link
Collaborator Author

reese commented Nov 19, 2022

Maybe, but I would treat those as out of scope for this PR (you'll probably want to open a separate ticket for that)

@reese reese merged commit f11f030 into trunk Nov 20, 2022
@reese reese deleted the reese-gemfile-methods branch November 22, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Gemfile gem method as special, un-parenthesised method
3 participants