Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document .rubyfmtignore and .gitignore behavior #357

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

reese
Copy link
Collaborator

@reese reese commented Nov 13, 2022

Resolves #354

We added support for ignore-files some time ago, and I think some users will find them pretty useful, especially in bigger projects, so adding some docs to the README for them.

@matthewford
Copy link

matthewford commented Nov 14, 2022

Hi, I'm trying out using .rubyfmtignore with VS Code. However, it looks like the file is not being respected.

@fables-tales fables-tales merged commit a65b40b into trunk Nov 14, 2022
@reese reese deleted the reese-document-rubyfmtignore branch November 14, 2022 16:08
@reese
Copy link
Collaborator Author

reese commented Nov 14, 2022

@matthewford is it respected if you run rubyfmt directly in the root directory?

@matthewford
Copy link

@reese I suspect it is.

@reese
Copy link
Collaborator Author

reese commented Nov 19, 2022

In that case, that sounds like something in the VSCode extension and should probably be filed as an issue there. I don't have a ton of context on how that extension works though.

@reese
Copy link
Collaborator Author

reese commented Nov 19, 2022

Ah it looks like it passes things through stdin, which is probably why this doesn't work. I had a thought that we should support something like --stdin-filepath that prettier has, which is basically "format these contents but treat them like they're at this file path to handle e.g. file ignores," but we don't have that currently (tracking in #365)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VSCode integration with --header-opt-out
3 participants