Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and try fix GH Pages publish action. #953

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

tristanmorgan
Copy link
Member

from the latest version of the gh-pages docs it should use GITHUB_TOKEN to authenticate...

@tristanmorgan
Copy link
Member Author

@aaronhurt tested on my fork see

Copy link
Contributor

@dcarbone dcarbone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change, otherwise lgtm

github_token: ${{ secrets.GH_ACTIONS_TOKEN }}
publish_dir: ./docs/public
cname: fabiolb.net
- uses: actions/checkout@master
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this to @v4, please

Copy link
Member

@nathanejohnson nathanejohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like there are whitespace issues with this commit as well, the file uses spaces for indent

@tristanmorgan
Copy link
Member Author

I pinned the actions/checkout version to v4, and dropped the formatting commit.

@tristanmorgan tristanmorgan deleted the fix_gh_pages branch September 9, 2024 03:57
@tristanmorgan tristanmorgan restored the fix_gh_pages branch September 9, 2024 03:57
@tristanmorgan tristanmorgan reopened this Sep 9, 2024
@tristanmorgan tristanmorgan merged commit 5637475 into fabiolb:master Sep 9, 2024
3 checks passed
@tristanmorgan tristanmorgan deleted the fix_gh_pages branch September 9, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants