-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and try fix GH Pages publish action. #953
Conversation
@aaronhurt tested on my fork see |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change, otherwise lgtm
.github/workflows/github-pages.yml
Outdated
github_token: ${{ secrets.GH_ACTIONS_TOKEN }} | ||
publish_dir: ./docs/public | ||
cname: fabiolb.net | ||
- uses: actions/checkout@master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change this to @v4
, please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like there are whitespace issues with this commit as well, the file uses spaces for indent
cde52b8
to
2f757f6
Compare
I pinned the actions/checkout version to v4, and dropped the formatting commit. |
from the latest version of the gh-pages docs it should use GITHUB_TOKEN to authenticate...