Feature/source link #907
Merged
Feature/source link #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is (with settings and such) way bolder than I could ever wish for. When hitting |
|
That issue should be fixed, i had pushed the initial changes before finding that bug, but it builds ok now and should be good. |
|
I tested |
|
|
…ource and make it linkable with options, updated documentation update documentation and logic for setting the port fixed bug putting the scheme and host in the correct places in JS in the routes file and added the hugo build file to the git ignore file update routing table source field to clickable link the logic of making the source field in the routing table was incomplete. updated so that it would account for if the source had a port in it already, and if it does then use that port instead of what is provided additionally added line/logic to turn the row red IF the source is invalid (by beginning with http) adding icon and tooltip hover text to error messaging
KTruesdellENA
force-pushed
the
feature/source-link
branch
from
ffad225 to
fc7a2d0
Compare
nathanejohnson
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Kamilcuk
Added your changes and made it a configurable variable. Can you review please?