#865 Move the route table sort into NewTable so that it only happens once. #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ddreier
force-pushed
the
issue-865-consul-slow-updates
branch
from
cdf27fe to
c799fb3
Compare
nathanejohnson
approved these changes
Apr 8, 2022
|
So I have to ask... why do you guys have so many routes? :) |
We like to ask ourselves the same thing 😄 Our Production Nomad clusters each run around 20k Allocations (we run mostly single-tenant services). Depending on the actual application, there could be as many as 6 or 8 routes registered per Alloc. So it ends up that we have Fabio instances for a couple of networks that have 60k routes. |
|
Thank you for your contribution! |
|
Thanks @nathanejohnson! Any hint on when the next version might be released? 😄 |
|
@ddreier it was just released today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #865 where route table updates take multiple minutes with tens of thousands of routes.