Fix SSE by implementing Flusher in responseWriter wrapper #655
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed after upgrading to any version later than 1.5.8 that server-sent events stopped working. It looks like the responseWriter wrapper added in #470 does not implement the
http.Flusher
interface, so events are never flushed to the client.Adding
Flush()
to the wrapper fixes the issue and server-sent events are working for me again.