-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added idleTimout to config and to serve.go HTTP server #635
Conversation
I don't have access to codeship so I can't see what is broken in the testing. I can say that locally the tests I updated pass
|
Hmm, let me have a look. |
Can you send me your email address to [email protected]? Then I'll invite you to the codeship project. We should put this on some other CI/CD platform IMO. |
Damn, I think I've messed up the repo since I forgot to push the release changes from 1.5.11 and did a pull rebase. Do not pull changes right now until I've fixed this. |
I could setup a Travis build file. |
yes, we could do that again. Last config was 3a04a7c |
I think there was some issue with the verbose test logs being too long or so. Don't remember why I switched. |
Ah right, tests on travis were highly volatile. Passing test was hit and miss. What about CircleCI? |
Circle works for me. I'll give it a shot. |
Re repo: damage is done but it isn't major. I've added a note to the Changelog regarding v1.5.11 release. Basically I forgot to push the last four commits after I did the release which only includes updates to more recent versions of consul and vault to test with. The release process itself wants two commits for changelog and main.go but I did that in one, reverted and fixed that. Sorry about that :( |
@leprechau I've done a fair amount of CircleCI wrangling the last couple of weeks. See how far you get and I can pick up in the morning. ZZZ time here. |
@galen0624 sorry for turning your PR into this CI/CD storm. |
No worries. We use drone https://github.com/drone/drone internally and it seems OK. Not great but its another option. |
But we'd have to run that somewhere, right? |
yes so probably not the best option. |
4989fc2
to
2a77ba3
Compare
Rebased with current Master |
Triggering a rebuild with Travis. |
@galen0624 Thank you again! |
#634