Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added support for Consul TLS transport #602

Merged
merged 2 commits into from
Apr 4, 2019
Merged

added support for Consul TLS transport #602

merged 2 commits into from
Apr 4, 2019

Conversation

sev3ryn
Copy link
Contributor

@sev3ryn sev3ryn commented Feb 9, 2019 •
edited by magiconair
Loading

This change adds option for Fabio to connect Consul using TLS transport.

Copy of PR #391 while it seems to be incorrect and abandoned.

Closes #276

@CLAassistant
Copy link

CLAassistant commented Feb 9, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@magiconair magiconair added this to the 1.5.12 milestone Feb 25, 2019
aaronhurt
aaronhurt approved these changes Feb 25, 2019
View reviewed changes
Copy link
Member

@aaronhurt aaronhurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and thank you for following the existing spacing in the properties file 👍

@aaronhurt aaronhurt merged commit f6ad1b8 into fabiolb:master Apr 4, 2019
@pires
Copy link
Contributor

pires commented Jun 1, 2019

#391 can then be closed, no?

@pires pires mentioned this pull request Jun 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronhurt aaronhurt aaronhurt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.12
Development

Successfully merging this pull request may close these issues.

Support Consul TLS
5 participants
@sev3ryn @CLAassistant @pires @aaronhurt @magiconair