-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix includes for inclusion as an external project #44
Conversation
Closes #43 |
@Shillaker I was trying to rebuild this myself, but the To replicate just run the steps in the workflow file: inv dev.cmake --shared
inv dev.cc faabric --shared
inv dev.install faabric --shared
inv examples To workaround this issue, we need to link with protobuf in examples/CMakeLists. The following works for me: target_link_libraries(${example_name}
${FAABRIC_LIBS}
pistache
protobuf
) PS: I think this is not completely right, just a workaround that happens to work in my machine. I will now have a look into why the tests actually pass. |
* Public include dirs for libraries * Update all includes * Add spdlog dependency * Formatting * Adding linkage between object library and normal library * Build proto headers first * Missing dependency * Fixing up examples build
When using Faabric as an external project it can either be added with
add_subdirectory
in which case we need the publictarget_include_directories
or as an installed library in which case the transitive header includes should still work.