Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transport(tcp): remove sendMany function #423

Merged
merged 1 commit into from
Apr 16, 2024
Merged

transport(tcp): remove sendMany function #423

merged 1 commit into from
Apr 16, 2024

Conversation

csegarragonz
Copy link
Collaborator

Turns out that sendMany becomes very convoluted when we need to handle partial writes. As it is not very clear the benefit that we are getting from it, and we may get away without it, we remove it in this PR.

I also fix the handling of partial writes for the sendOne method.

Turns out that sendMany becomes very convoluted when we need to handle
partial writes. As it is not very clear the benefit that we are getting
from it, and we may get away without it, we remove it in this PR.

I also fix the handling of partial writes for the sendOne method.
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 82.27%. Comparing base (0c3120d) to head (1464836).

Files Patch % Lines
src/mpi/MpiWorld.cpp 42.85% 8 Missing ⚠️
src/transport/tcp/RecvSocket.cpp 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #423      +/-   ##
==========================================
+ Coverage   82.23%   82.27%   +0.04%     
==========================================
  Files         116      115       -1     
  Lines        7570     7556      -14     
==========================================
- Hits         6225     6217       -8     
+ Misses       1345     1339       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@csegarragonz csegarragonz merged commit bb8c00e into main Apr 16, 2024
11 of 12 checks passed
@csegarragonz csegarragonz deleted the no-send-many branch April 16, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant