Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shared object build #36

Merged
merged 13 commits into from
Dec 8, 2020
Merged

Shared object build #36

merged 13 commits into from
Dec 8, 2020

Conversation

Shillaker
Copy link
Collaborator

@Shillaker Shillaker commented Dec 4, 2020 •
edited
Loading

Adding shared object builds of gRPC and Faabric

@Shillaker Shillaker marked this pull request as draft December 4, 2020 16:07
@Shillaker Shillaker changed the title Add shared object builds for gRPC Add shared object build Dec 4, 2020
@Shillaker Shillaker changed the title Add shared object build Shared object build Dec 4, 2020
@Shillaker Shillaker marked this pull request as ready for review December 7, 2020 12:10
@csegarragonz
Copy link
Collaborator

LGTM, but there seems to be a problem with the tests.

@Shillaker Shillaker marked this pull request as draft December 7, 2020 17:55
@Shillaker Shillaker marked this pull request as ready for review December 8, 2020 15:19
@Shillaker Shillaker merged commit 7f8b43a into master Dec 8, 2020
@Shillaker Shillaker deleted the shared-objs branch December 8, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csegarragonz csegarragonz csegarragonz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shillaker @csegarragonz