Set appid on messages (#137)

* Set app id * Add tests for app id
faasm · Sep 8, 2021 · 0ff6027 · 0ff6027
1 parent ca9a5c3
commit 0ff6027
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/src/util/func.cpp b/src/util/func.cpp
@@ -115,6 +115,11 @@ unsigned int setMessageId(faabric::Message& msg)
         msg.set_id(messageId);
     }
 
+    // Set an app ID if not already set
+    if (msg.appid() == 0) {
+        msg.set_appid(faabric::util::generateGid());
+    }
+
     // Set the timestamp if it doesn't have one
     if (msg.timestamp() <= 0) {
         Clock& clock = faabric::util::getGlobalClock();

diff --git a/tests/test/util/test_func.cpp b/tests/test/util/test_func.cpp
@@ -30,25 +30,30 @@ TEST_CASE("Test message factory shared", "[util]")
     REQUIRE(!msg->resultkey().empty());
 }
 
-TEST_CASE("Test adding id to message", "[util]")
+TEST_CASE("Test adding ids to message", "[util]")
 {
     faabric::Message msgA;
     faabric::Message msgB;
 
     REQUIRE(msgA.id() == 0);
     REQUIRE(msgA.resultkey().empty());
     REQUIRE(msgA.statuskey().empty());
+    REQUIRE(msgA.appid() == 0);
 
     REQUIRE(msgB.id() == 0);
     REQUIRE(msgB.resultkey().empty());
     REQUIRE(msgB.statuskey().empty());
+    REQUIRE(msgB.appid() == 0);
 
     faabric::util::setMessageId(msgA);
     faabric::util::setMessageId(msgB);
 
     REQUIRE(msgA.id() > 0);
+    REQUIRE(msgA.appid() > 0);
     REQUIRE(msgB.id() > 0);
+    REQUIRE(msgB.appid() > 0);
     REQUIRE(msgB.id() > msgA.id());
+    REQUIRE(msgB.appid() > msgA.appid());
 
     std::string expectedResultKeyA =
       std::string("result_" + std::to_string(msgA.id()));
@@ -65,21 +70,24 @@ TEST_CASE("Test adding id to message", "[util]")
     REQUIRE(msgB.statuskey() == expectedStatusKeyB);
 }
 
-TEST_CASE("Test adding ID to message with an existing ID")
+TEST_CASE("Test adding ids to message with existing ids")
 {
     faabric::Message msg;
     faabric::util::setMessageId(msg);
 
     int originalId = msg.id();
+    int originalAppId = msg.appid();
     std::string originalStatusKey = msg.statuskey();
     std::string originalResultKey = msg.resultkey();
 
     faabric::util::setMessageId(msg);
     int afterId = msg.id();
+    int afterAppId = msg.appid();
     std::string afterStatusKey = msg.statuskey();
     std::string afterResultKey = msg.resultkey();
 
     REQUIRE(afterId == originalId);
+    REQUIRE(afterAppId == originalAppId);
     REQUIRE(afterStatusKey == originalStatusKey);
     REQUIRE(afterResultKey == originalResultKey);
 }