Skip to content

Commit

Permalink
[receiver/vcenter] Change Host Perf Metric Reported Datapoints From 5…
Browse files Browse the repository at this point in the history
… to 1 (open-telemetry#34708)

**Description:** <Describe what has changed.>
This is something that I thought was a little odd for awhile, but didn't
necessarily hurt anything until I ran into issues with the googlecloud
exporter. It seems to have issues with the Host performance metrics
sending historical data with timestamps 20s apart and reported it as a
Duplicate error.

This also brings the Host performance metrics in line with what is being
done with the VM performance metrics (only sending a single current
datapoint vs 5 historical ones). Now we'll also generally avoid
situations where timetamps at the tail end of these 5 datapoints would
end up being picked up by the following collection as well.

**Link to tracking Issue:** NA

**Testing:**
Unit Tests Ran
Integration Tests Ran
Tested Against Live Environment

**Documentation:** <Describe the documentation added.>
None needed

---------

Co-authored-by: Daniel Jaglowski <[email protected]>
  • Loading branch information
2 people authored and f7o committed Sep 12, 2024
1 parent bb16ae4 commit 23bcee8
Show file tree
Hide file tree
Showing 5 changed files with 1,303 additions and 10,149 deletions.
42 changes: 42 additions & 0 deletions .chloggen/vcenter-receiver_remove_extra_host_perf_metrics.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: breaking

# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
component: vcenterreceiver

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Several host performance metrics now return 1 data point per time series instead of 5.

# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
issues: [34708]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext: |
The 5 data points previously sent represented consecutive 20s sampling periods. Depending on the collection interval
these could easily overlap. Sending just the latest of these data points is more in line with other performance metrics.
This change also fixes an issue with the googlecloud exporter seeing these datapoints as duplicates.
Following is the list of affected metrics which will now only report a single datapoint per set of unique attribute values.
- vcenter.host.cpu.reserved
- vcenter.host.disk.latency.avg
- vcenter.host.disk.latency.max
- vcenter.host.disk.throughput
- vcenter.host.network.packet.drop.rate
- vcenter.host.network.packet.error.rate
- vcenter.host.network.packet.rate
- vcenter.host.network.throughput
- vcenter.host.network.usage
# If your change doesn't affect end users or the exported elements of any package,
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: [user]
Loading

0 comments on commit 23bcee8

Please sign in to comment.