[issue 195] terminate streams gracefully #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moh-osman3
changed the title
jmacd
reviewed
Aug 2, 2023
jmacd
approved these changes
Aug 2, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #195
This PR solves an issue with stream termination, where once
max_connection_ageis reached in the server (otlpreceiver), it will shutdown and return aNO_ERRORerror to the client. To resolve this, the client (otlpexporter) will set amax_stream_lifetimein the config to signal a graceful shutdown in the client before the server reaches themax_connection_ageFor testing I ran the arrow collector with a
record.yamlwhich had a telemetry generator receiver -> otlpexporter -> otlpreceiver -> fileexporter pipeline, and confirmed I was no longer seeing thearrow stream shutdownerror