Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve window doc and test #304

Merged
merged 7 commits into from
May 30, 2022
Merged

Improve window doc and test #304

merged 7 commits into from
May 30, 2022

Conversation

mwestphal
Copy link
Contributor

@mwestphal mwestphal commented May 30, 2022 •
edited
Loading

  • Add window testing
  • Add window doc
  • Add error ref param to image compare
  • Improve TestSDKHelpers

@mwestphal mwestphal force-pushed the window_doc_test branch 2 times, most recently from 0c41a48 to 22607db Compare May 30, 2022 14:17
@codecov
Copy link

codecov bot commented May 30, 2022 •
edited
Loading

Codecov Report

Merging #304 (8c923b3) into master (8f09011) will increase coverage by 0.00%.
The diff coverage is 98.14%.

@@           Coverage Diff           @@
##           master     #304   +/-   ##
=======================================
  Coverage   89.17%   89.18%           
=======================================
  Files          90       90           
  Lines        4390     4394    +4     
=======================================
+ Hits         3915     3919    +4     
  Misses        475      475
Impacted Files Coverage Δ
library/public/image.h 100.00% <ø> (ø)
library/public/window.h 100.00% <ø> (ø)
library/VTKExtensions/Rendering/vtkF3DRenderer.cxx 97.83% <90.90%> (-0.24%) ⬇️
application/F3DStarter.cxx 98.14% <100.00%> (ø)
library/src/image.cxx 99.02% <100.00%> (+0.01%) ⬆️
library/src/window_impl_standard.cxx 99.27% <100.00%> (+0.72%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Meakk
Meakk approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@Meakk Meakk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, feel free to ignore, we can do it later

library/public/window.h Show resolved Hide resolved
@mwestphal mwestphal changed the title Window doc test Improve window doc and test May 30, 2022
@mwestphal mwestphal merged commit 086e806 into f3d-app:master May 30, 2022
@mwestphal mwestphal deleted the window_doc_test branch July 10, 2022 17:31
mwestphalnew pushed a commit to mwestphalnew/f3d that referenced this pull request Feb 10, 2024
@mwestphal
Merge pull request f3d-app#304 from mwestphal/window_doc_test
4a985f9 
    Add window testing
    Add window doc
    Add error ref param to image compare
    Improve TestSDKHelpers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Meakk Meakk Meakk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mwestphal @Meakk