Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use external json lib and move files to app #255

Merged
merged 1 commit into from
May 1, 2022

Conversation

Meakk
Copy link
Member

@Meakk Meakk commented Mar 28, 2022

  • Include an external json library (will be in the application in the long run)
  • Move some files to the application
  • Create a f3d_embed_file to replace vtk_encode_string

@Meakk Meakk self-assigned this Mar 28, 2022
@Meakk Meakk force-pushed the options-rework branch 5 times, most recently from 1a3b387 to 0478c0e Compare March 29, 2022 21:27
@Meakk Meakk changed the title Options rework Use external json lib and move files to app Mar 29, 2022
@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #255 (38e03b6) into master (8cb2fc5) will decrease coverage by 17.68%.
The diff coverage is 90.00%.

❗ Current head 38e03b6 differs from pull request most recent head 923402c. Consider uploading reports for the commit 923402c to get more accurate results

@@             Coverage Diff             @@
##           master     #255       +/-   ##
===========================================
- Coverage   88.03%   70.35%   -17.69%     
===========================================
  Files          89       91        +2     
  Lines        4372     6280     +1908     
===========================================
+ Hits         3849     4418      +569     
- Misses        523     1862     +1339     
Impacted Files Coverage Δ
src/application/F3DStarter.h 100.00% <ø> (ø)
src/library/F3DOptions.h 100.00% <ø> (ø)
...ry/VTKExtensions/Readers/vtkF3DAlembicImporter.cxx 83.54% <ø> (ø)
src/library/json.hpp 29.88% <ø> (ø)
src/library/F3DOptions.cxx 96.99% <87.50%> (-0.59%) ⬇️
src/application/F3DStarter.cxx 86.59% <100.00%> (ø)
src/application/main.cxx 100.00% <100.00%> (ø)
src/library/f3d_window_impl_standard.cxx 98.43% <100.00%> (+0.01%) ⬆️
src/library/f3d_options.cxx 74.32% <0.00%> (-0.52%) ⬇️
src/library/f3d_log.h 100.00% <0.00%> (ø)
... and 8 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@Meakk Meakk force-pushed the options-rework branch 4 times, most recently from 5fb36b6 to adb4212 Compare April 4, 2022 14:55
@Meakk Meakk requested a review from mwestphal April 4, 2022 14:57
.github/actions/vtk-install-dep/action.yml Show resolved Hide resolved
src/application/CMakeLists.txt Show resolved Hide resolved
src/application/CMakeLists.txt Outdated Show resolved Hide resolved
src/application/F3DStarter.cxx Show resolved Hide resolved
src/library/F3DOptions.cxx Show resolved Hide resolved
src/library/f3d_window_impl_standard.cxx Outdated Show resolved Hide resolved
src/library/f3d_window_impl_standard.cxx Outdated Show resolved Hide resolved
src/library/f3d_window_impl_standard.cxx Outdated Show resolved Hide resolved
@Meakk Meakk force-pushed the options-rework branch 7 times, most recently from c8baa0a to fb79611 Compare April 29, 2022 10:24
src/library/f3d_engine.h Show resolved Hide resolved
src/library/f3d_options.h Show resolved Hide resolved
@mwestphal mwestphal merged commit 71565a6 into f3d-app:master May 1, 2022
@mwestphal mwestphal mentioned this pull request May 20, 2022
10 tasks
mwestphalnew pushed a commit to mwestphalnew/f3d that referenced this pull request Feb 10, 2024
Use external json lib and move files to app
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants