Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F3D: Fix a small issue with imperative options #2049

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

mwestphal
Copy link
Contributor

  • Fix an issue with imperative options not taken into account when loading no data
  • Improve logging logic of options, logging them only once
  • Rework remove_file_groups to rely on LoadFileGroup
  • Add testing for the bugfix

Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.79%. Comparing base (bf0fc02) to head (cc04c5d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2049      +/-   ##
==========================================
- Coverage   95.82%   95.79%   -0.03%     
==========================================
  Files         128      128              
  Lines       10494    10498       +4     
==========================================
+ Hits        10056    10057       +1     
- Misses        438      441       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mwestphal mwestphal merged commit 0016594 into f3d-app:master Mar 6, 2025
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants