Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

options: Add support for path using std::filesystem::path #2046

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

mwestphal
Copy link
Contributor

@mwestphal mwestphal commented Mar 5, 2025

  • Add a _option_variant_convert logic in f3dOptions.cmake for conversion from an option type to a variant type
  • Add path aka std::filesystem::path has a valid option type
  • Add parse/format for path
  • Use path for hdri.file, font_file, all texture options
  • Add functionnal, unit and coverage testing
  • Add doc
  • Added deprecation code for collapse behavior

related to #1570

Copy link

github-actions bot commented Mar 5, 2025

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: python, java, webassembly.

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.80%. Comparing base (9d5bc10) to head (dfd2db9).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2046      +/-   ##
==========================================
+ Coverage   95.79%   95.80%   +0.01%     
==========================================
  Files         128      128              
  Lines       10485    10499      +14     
==========================================
+ Hits        10044    10059      +15     
+ Misses        441      440       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

## String

Path are formatted by creating a [std::filesystem::path](https://en.cppreference.com/w/cpp/filesystem/path/path)
and then collapsed using [f3d::utils::collapsePath](https://f3d.app/doc/libf3d/doxygen/api/classf3d_1_1utils.html#_CPPv4N3f3d5utils12collapsePathERKNSt10filesystem4pathERKNSt10filesystem4pathE).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im not convinced by my doc here but I also do not know if I should be super specific.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant