Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to list rendering backends #1831

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

Meakk
Copy link
Member

@Meakk Meakk commented Dec 23, 2024

Fix #1697

Add information about available rendering backends

@Meakk Meakk self-assigned this Dec 23, 2024
Copy link

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: python, java, webassembly.

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.64%. Comparing base (9852dab) to head (5ef9130).

Files with missing lines Patch % Lines
library/src/engine.cxx 92.30% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1831   +/-   ##
=======================================
  Coverage   95.64%   95.64%           
=======================================
  Files         123      123           
  Lines        9763     9786   +23     
=======================================
+ Hits         9338     9360   +22     
- Misses        425      426    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@snoyer
Copy link
Contributor

snoyer commented Dec 23, 2024

would need to use --rendering-backends-list (plural) to match --readers-list and --bindings-list
However I believe the singular is grammatically correct so the other 2 would need to change instead/eventually?

@Meakk Meakk requested a review from mwestphal December 23, 2024 15:44
@@ -65,7 +65,7 @@ The third block specifies raytracing usage for .gltf and .glb files.
The last block specifies that volume rendering should be used with .mhd files.

The following options <b> cannot </b> be set via config file:
`help`, `version`, `readers-list`, `config`, `dry-run` and `input`.
`help`, `version`, `list-readers`, `config`, `dry-run` and `input`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think list-rendering-backends and scan-plugins should be added here

@@ -13,7 +13,7 @@ Options|Default|Description
\-\-no-background||Use with \-\-output to output a png file with a transparent background.
-h, \-\-help||Print *help* and exit. Ignore `--verbose`.
\-\-version||Show *version* information and exit. Ignore `--verbose`.
\-\-readers-list||List available *readers* and exit. Ignore `--verbose`.
\-\-list-readers||List available *readers* and exit. Ignore `--verbose`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd expect list-bindings and list-rendering-backends to appear in this file

Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide info about available rendering backends
3 participants