libf3d: Improve API for C++17 support #1830
Open
+154
−136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mwestphal
commented
Dec 23, 2024
•
mwestphal
commented
- Adding [[nodiscard]] on all method where it makes sense
- Updating test to use std::ignore when needed
- Return this* whenever is was missing
|
You are modifying libf3d public API! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1830 +/- ##
==========================================
+ Coverage 95.64% 95.67% +0.03%
==========================================
Files 123 123
Lines 9763 9764 +1
==========================================
+ Hits 9338 9342 +4
+ Misses 425 422 -3 ☔ View full report in Codecov by Sentry. |
mwestphal
changed the title
- Adding [[nodiscard]] on all method where it makes sense - Updating test to use std::ignore when needed
mwestphal
force-pushed
the
add_discard
branch
from
8ce8918 to
9fd5c41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.