Change camera API to be more explicit #1820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You are modifying libf3d public API! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1820 +/- ##
==========================================
+ Coverage 95.68% 95.71% +0.03%
==========================================
Files 123 123
Lines 9756 9756
==========================================
+ Hits 9335 9338 +3
+ Misses 421 418 -3 ☔ View full report in Codecov by Sentry. |
pos -> position up -> viewUp foc -> focalPoint angle -> viewAngle
mwestphal
force-pushed
the
change_camera_api
branch
from
b2558f8 to
0cac02c
Compare
Meakk
approved these changes
Dec 21, 2024
snoyer
reviewed
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pos -> position
up -> viewUp
foc -> focalPoint
angle -> viewAngle
Fix #1531