Updating CLI options names for clarity #1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwestphal
force-pushed
the
rename_cli_options
branch
from
86c6afb to
fee7b15
Compare
progress -> loading-progress trackball -> interaction-trackball cells -> coloring-by-cells range -> coloring-range bar -> coloring-scalar-bar inverse -> volume-inverse samples -> raytracing-samples denoise -> raytracing-denoise ref -> reference ref-threshold -> reference-threshold
mwestphal
force-pushed
the
rename_cli_options
branch
from
b0a6491 to
64bdc81
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1819 +/- ##
=======================================
Coverage 95.68% 95.68%
=======================================
Files 123 123
Lines 9756 9757 +1
=======================================
+ Hits 9335 9336 +1
Misses 421 421 ☔ View full report in Codecov by Sentry. |
Meakk
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
progress -> loading-progress
trackball -> interaction-trackball
cells -> coloring-by-cells
range -> coloring-range
bar -> coloring-scalar-bar
inverse -> volume-inverse
samples -> raytracing-samples
denoise -> raytracing-denoise
ref -> reference
ref-threshold -> reference-threshold
Fix #1530