Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Fix an issue with option test #1646

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

mwestphal
Copy link
Contributor

No description provided.

@mwestphal mwestphal requested a review from Meakk October 4, 2024 06:07
@mwestphal
Copy link
Contributor Author

@snoyer please review

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.85%. Comparing base (bcedd6d) to head (04abf6f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1646   +/-   ##
=======================================
  Coverage   96.85%   96.85%           
=======================================
  Files         108      108           
  Lines        7691     7691           
=======================================
  Hits         7449     7449           
  Misses        242      242           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@snoyer
Copy link
Contributor

snoyer commented Oct 4, 2024

looks good, I guess it did provide coverage before but it's indeed better if actually tests for correctness too :)

@mwestphal mwestphal merged commit 544ae70 into f3d-app:master Oct 4, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants