improve options parsing #1616
Merged
improve options parsing #1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
snoyer
commented
Sep 11, 2024
mwestphal
reviewed
Sep 13, 2024
mwestphal
reviewed
Sep 13, 2024
mwestphal
reviewed
Sep 13, 2024
mwestphal
reviewed
Sep 13, 2024
mwestphal
reviewed
Sep 13, 2024
mwestphal
reviewed
Sep 13, 2024
mwestphal
reviewed
Sep 13, 2024
mwestphal
reviewed
Sep 13, 2024
mwestphal
reviewed
Sep 13, 2024
mwestphal
reviewed
Sep 13, 2024
mwestphal
reviewed
Sep 14, 2024
mwestphal
reviewed
Sep 14, 2024
mwestphal
reviewed
Sep 14, 2024
mwestphal
requested changes
Sep 14, 2024
mwestphal
approved these changes
Sep 14, 2024
Meakk
approved these changes
Sep 14, 2024
Nokse22
pushed a commit
to Nokse22/f3d
that referenced
this pull request
Sep 21, 2024
First pass on the new options IO. Here we improve parsing for the existing `bool`, `int`, `double`, `ratio_t` types. Also split the IO tests from the options structure tests (the options tests could possibly be reduced in the future as they currently also do some parsing/formatting test).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass on the new options IO. Here we improve parsing for the existing
bool,int,double,ratio_ttypes.I also split the IO tests from the options structure tests (the options tests could possibly be reduced in the future as they currently also do some parsing/formatting test).