minor fixes to TestSDKHelpers.h
#1614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwestphal
reviewed
Sep 10, 2024
mwestphal
approved these changes
Sep 10, 2024
Nokse22
pushed a commit
to Nokse22/f3d
that referenced
this pull request
Sep 21, 2024
* add missing includes * turn class into namespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestSDKHelpers.his missing some includes, which isn't a problem as they are currently always already included before any use of the file, but still, let's have them in there.Also
class TestSDKHelpersonly has static methods and holds no state so it can be a namespace instead