fix: terminate f3d process spawned by F3DShellExtension if its still active after timeout

[chirag-droid]

Previous Behaviour

If you previewed a thumbnail that took longer than 8 sec, the thumbnail would return in E_FAIL but wouldn't properly terminate the process associated with it. And continue running in the background.

Current Behaviour

The spawned process is properly terminated.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4a525fd) 96.57% compared to head (ec603b6) 96.57%.
Report is 3 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1291   +/-   ##
=======================================
  Coverage   96.57%   96.57%           
=======================================
  Files         138      138           
  Lines        8494     8500    +6     
=======================================
+ Hits         8203     8209    +6     
  Misses        291      291           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[chirag-droid]

related to #300 #441

[Meakk]

Looks good to me, but I'm not a Win32 expert. @mwestphal wdyt?

[chirag-droid]

I am sure this only solves a part of the puzzle.

It needs a proper investigation. And its difficult without someone from windows dev team.

The function should return a default icon instead of returning error so windows saves it in cache. Or something like that.

[mwestphal]

f you previewed a thumbnail that took longer than 8 sec,

Is this a Windows limitation ? in any case, the fix is good, there is no reason to leave the process running if Windows is not going ot do anything with it.

Dataset that are too slow to be opened but smaller than the max-size we should study to understand why they are slow, which is why @snoyer is doing in #1292 :)

[chirag-droid]

f you previewed a thumbnail that took longer than 8 sec,

Is this a Windows limitation ? in any case, the fix is good, there is no reason to leave the process running if Windows is not going ot do anything with it.

Its actually a timeout set in the code. The timeout can be changed by a compile definition.

In CMakeLists.txt it is set to 8000ms

[chirag-droid]

https://github.com/f3d-app/f3d/blob/master/winshellext%2FCMakeLists.txt#L9