Handle commas in filenames

[snoyer]

This should work around cxxopts splitting filenames on commas by retrieving the filenames from the unmatched arguments rather than into a vector<string> option.

This comes at the cost of the --input named argument but I'm unclear if having the filenames as both positional and named args is useful, so hopefully it's fine?

The TestHelpPositional test fails as, contrary to what its name suggest, it checks for --input in the help text,
Should it have been looking for file1 file2 ... this whole time? or should it have been named something like TestHelpInputArg in the first place?

edit: after @mwestphal request for backward compatibility:

• the --input argument is kept but deprecated as it would be a lot of work to make it work with commas
• the positional filenames are handled through the unmatched arguments instead of parse_positional and commas are ok there

would fix #1070

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8641276) 96.42% compared to head (ada3451) 96.43%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1078   +/-   ##
=======================================
  Coverage   96.42%   96.43%           
=======================================
  Files         124      124           
  Lines        7671     7679    +8     
=======================================
+ Hits         7397     7405    +8     
  Misses        274      274           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mwestphal]

Only small changes required

[mwestphal]

@Meakk ptal

[Meakk]

Nice workaround, it's a shame we have to do that but I can live with it.

[mwestphal]

Arent we suposed to have a filename visible on this baseline ?

[mwestphal]

actually, no, I got baited by the name of the test, although displaying the filename in the test would kinda make sense.

[Alex-Kent]

For anyone using an older version on *nix, here's a partial work-around. This can be specified as the program to use to open a file when double-clicking on it from one's file manager. It takes a single argument (the file's path). Adjust f3d's command line options to taste within the script as they can't be passed on the command line. Place the script into e.g. /usr/local/bin/f3d-wrapper

#!/bin/bash

IFS=$(echo -en "\n\b")

d=$( dirname $1 )
f=$( basename $1 )

cd "$d"
f3d "$f" --bg-color=0.1,0.1,0.1 --roughness=0.5 --ssao --tone-mapping