Reader alembic uv normal support #1055
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicholas Yue <[email protected]>
Remove unused code Remove commented out debugging print out
Mostly bad use of auto
Also updated the baseline test image for Alembic. Signed-off-by: Nicholas Yue <[email protected]>
Signed-off-by: Nicholas Yue <[email protected]>
Mostly basic code clean up and improvement. There are additional changes that contains logic changes. Those changes will be in another commit. Signed-off-by: Nicholas Yue <[email protected]>
I am keeping this available for now in anticipation of edge cases where we do need to perform the operations. When the code is use with my production assets, we might encounter such edge cases. When the follow release of f3d comes along and we still have not encounter such edge cases, I can remove it. Signed-off-by: Nicholas Yue <[email protected]>
Signed-off-by: Nicholas Yue <[email protected]>
Signed-off-by: Nicholas Yue <[email protected]>
Signed-off-by: Nicholas Yue <[email protected]>
|
@nyue did you need any help finishing this one ? Should we fix the CI issues for you ? |
|
Yes I do. I believe @Meakk will circle back to looking at the CI side of things as per Discord discussion. |
|
I'm currently very busy but I haven't forgot :) |
|
Sure, Ill take a look. |
|
@nyue you need to give me authorisation to push on your fork. Alternatively I can create a new PR. |
mwestphal
reviewed
Nov 15, 2023
| points->SetPoint(i, positions->get()[i].x, positions->get()[i].y, positions->get()[i].z); | ||
| auto this_face_vertex_count = original_data._indices[i].size(); | ||
| duplicated_data._indices[i].resize( | ||
| this_face_vertex_count, Alembic::Abc::V3i(-9999, -9999, -9999)); |
There was a problem hiding this comment.
what does -9999 correspond to @nyue ?
mwestphal
reviewed
Nov 15, 2023
|
|
||
| polys->SetData(offsets, connectivity); | ||
| auto P_map_iter = data._attributes.find("P"); | ||
| assert(P_map_iter != data._attributes.end()); |
There was a problem hiding this comment.
Can this actually happen @nyue ?
|
closing in favor of #1069 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.